Ignore:
Timestamp:
Jun 16, 2011, 3:01:43 PM (14 years ago)
Author:
[email protected]
Message:

2011-06-16 Geoffrey Garen <[email protected]>

Reviewed by Oliver Hunt.

Introduced SlotVisitor into the project
https://bugs.webkit.org/show_bug.cgi?id=62820


This resolves a class vs typedef forward declaration issue, and gives all
exported symbols the correct names.

  • bytecode/EvalCodeCache.h:
  • heap/HandleHeap.h:
  • heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::markRoots):
  • heap/Heap.h:
  • heap/HeapRootVisitor.h: Replaced MarkStack with SlotVisitor. Now no clients operate on a MarkStack.
  • heap/MarkStack.cpp: (JSC::SlotVisitor::visitChildren): (JSC::SlotVisitor::drain):
  • heap/SlotVisitor.h: Added. (JSC::SlotVisitor::SlotVisitor): Used 'protected' and a little cheesy inheritance to give SlotVisitor all the attributes of MarkStack without making this change giant. Over time, we will move more behavior into SlotVisitor and its subclasses.
  • heap/MarkStack.h:
  • heap/NewSpace.h: Replaced MarkStack with SlotVisitor. Now no clients operate on a MarkStack.
  • runtime/ArgList.h:
  • runtime/JSCell.h:
  • runtime/JSObject.h:
  • runtime/ScopeChain.h:
  • runtime/SmallStrings.h:
  • runtime/Structure.h: Replaced MarkStack with SlotVisitor. Now no clients operate on a MarkStack.

2011-06-16 Geoffrey Garen <[email protected]>

Reviewed by Oliver Hunt.

Introduced SlotVisitor into the project
https://bugs.webkit.org/show_bug.cgi?id=62820

This resolves a class vs typedef forward declaration issue, and gives all
exported symbols the correct names.

  • dom/EventListener.h:
  • dom/Node.h:
  • dom/NodeFilterCondition.h:
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/JavaScriptCore.exp

    r88587 r89069  
    156156__ZN3JSC14JSGlobalObject12defineGetterEPNS_9ExecStateERKNS_10IdentifierEPNS_8JSObjectEj
    157157__ZN3JSC14JSGlobalObject12defineSetterEPNS_9ExecStateERKNS_10IdentifierEPNS_8JSObjectEj
    158 __ZN3JSC14JSGlobalObject13visitChildrenERNS_9MarkStackE
     158__ZN3JSC14JSGlobalObject13visitChildrenERNS_11SlotVisitorE
    159159__ZN3JSC14JSGlobalObject16addStaticGlobalsEPNS0_18GlobalPropertyInfoEi
    160160__ZN3JSC14JSGlobalObject17putWithAttributesEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueEj
     
    173173__ZN3JSC14TimeoutChecker5resetEv
    174174__ZN3JSC14throwTypeErrorEPNS_9ExecStateE
    175 __ZN3JSC15JSWrapperObject13visitChildrenERNS_9MarkStackE
    176 __ZN3JSC15WeakHandleOwner26isReachableFromOpaqueRootsENS_6HandleINS_7UnknownEEEPvRNS_9MarkStackE
     175__ZN3JSC15JSWrapperObject13visitChildrenERNS_11SlotVisitorE
     176__ZN3JSC15WeakHandleOwner26isReachableFromOpaqueRootsENS_6HandleINS_7UnknownEEEPvRNS_11SlotVisitorE
    177177__ZN3JSC15WeakHandleOwner8finalizeENS_6HandleINS_7UnknownEEEPv
    178178__ZN3JSC15WeakHandleOwnerD2Ev
     
    262262__ZN3JSC6RegExp6createEPNS_12JSGlobalDataERKNS_7UStringENS_11RegExpFlagsE
    263263__ZN3JSC6RegExpD1Ev
    264 __ZN3JSC7JSArray13visitChildrenERNS_9MarkStackE
     264__ZN3JSC7JSArray13visitChildrenERNS_11SlotVisitorE
    265265__ZN3JSC7JSArray15setSubclassDataEPv
    266266__ZN3JSC7JSArray18getOwnPropertySlotEPNS_9ExecStateEjRNS_12PropertySlotE
     
    294294__ZN3JSC8JSObject12lookupGetterEPNS_9ExecStateERKNS_10IdentifierE
    295295__ZN3JSC8JSObject12lookupSetterEPNS_9ExecStateERKNS_10IdentifierE
    296 __ZN3JSC8JSObject13visitChildrenERNS_9MarkStackE
     296__ZN3JSC8JSObject13visitChildrenERNS_11SlotVisitorE
    297297__ZN3JSC8JSObject14deletePropertyEPNS_9ExecStateERKNS_10IdentifierE
    298298__ZN3JSC8JSObject14deletePropertyEPNS_9ExecStateEj
Note: See TracChangeset for help on using the changeset viewer.