Changeset 89100 in webkit for trunk/Source/JavaScriptCore/parser/Lexer.cpp

Timestamp:

Jun 16, 2011, 6:47:25 PM (14 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=23611
Multiline Javascript comments cause incorrect parsing of following script.

Reviewed by Oliver Hunt.

From the spec:
"A MultiLineComment [is] simply discarded if it contains no line terminator,
but if a MultiLineComment contains one or more line terminators, then it is
replaced with a single line terminator, which becomes part of the stream of
inputs for the syntactic grammar."

This may result in behavioural changes, due to automatic semicolon insertion.

Source/JavaScriptCore:

• parser/Lexer.cpp:

(JSC::Lexer::parseMultilineComment):

• Set m_terminator is we see a line terminator in a multiline comment.

LayoutTests:

• fast/js/multiline-comment-newline-expected.txt: Added.
• fast/js/multiline-comment-newline.html: Added.
• fast/js/script-tests/multiline-comment-newline.js: Added.

(shouldBeUndefined):

File:

• trunk/Source/JavaScriptCore/parser/Lexer.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/Lexer.cpp

@@ -737 +737 @@
             return false;
 
-        if (isLineTerminator(m_current))
+        if (isLineTerminator(m_current)) {
             shiftLineTerminator();
-        else
+            m_terminator = true;
+        } else
             shift();
     }