Changeset 89371 in webkit for trunk/Source/JavaScriptCore/parser/JSParser.cpp

Timestamp:

Jun 21, 2011, 12:30:31 PM (14 years ago)

Author:

[email protected]

Message:

2011-06-21 Oliver Hunt <​[email protected]>

Reviewed by Alexey Proskuryakov.

REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
​https://bugs.webkit.org/show_bug.cgi?id=63052

Release mode only failure, the stack overflow guards were getting there error
handling inlined, so that they were essentially causing their own demise.

• parser/JSParser.cpp: (JSC::JSParser::updateErrorMessage): (JSC::JSParser::updateErrorWithNameAndMessage):

File:

• trunk/Source/JavaScriptCore/parser/JSParser.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/parser/JSParser.cpp

@@ -392 +392 @@
     }
         
-    ALWAYS_INLINE void updateErrorMessage() 
+    NEVER_INLINE void updateErrorMessage() 
     {
         m_error = true;
@@ -402 +402 @@
     }
     
-    ALWAYS_INLINE void updateErrorMessage(JSTokenType expectedToken) 
+    NEVER_INLINE void updateErrorMessage(JSTokenType expectedToken) 
     {
         m_error = true;
@@ -412 +412 @@
     }
     
-    ALWAYS_INLINE void updateErrorWithNameAndMessage(const char* beforeMsg, UString name, const char* afterMsg) 
+    NEVER_INLINE void updateErrorWithNameAndMessage(const char* beforeMsg, UString name, const char* afterMsg) 
     {
         m_error = true;
@@ -424 +424 @@
     }
     
-    ALWAYS_INLINE void updateErrorMessage(const char* msg) 
+    NEVER_INLINE void updateErrorMessage(const char* msg) 
     {   
         m_error = true;