Changeset 89885 in webkit for trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

Timestamp:

Jun 27, 2011, 6:32:01 PM (14 years ago)

Author:

[email protected]

Message:

2011-06-27 Oliver Hunt <​[email protected]>

Reviewed by Geoffrey Garen.

Support throwing away non-running code even while other code is running
​https://bugs.webkit.org/show_bug.cgi?id=63485

Add a function to CodeBlock to support unlinking direct linked callsites,
and then with that in place add logic to discard code from any function
that is not currently on the stack.

The unlinking completely reverts any optimized call sites, such that they
may be relinked again in future.

• JavaScriptCore.exp:
• bytecode/CodeBlock.cpp: (JSC::CodeBlock::unlinkCalls): (JSC::CodeBlock::clearEvalCache):
• bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::unlink):
• bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::clear):
• heap/Heap.cpp: (JSC::Heap::getConservativeRegisterRoots):
• heap/Heap.h:
• jit/JIT.cpp: (JSC::JIT::privateCompile):
• jit/JIT.h:
• jit/JITCall.cpp: (JSC::JIT::compileOpCall):
• jit/JITWriteBarrier.h: (JSC::JITWriteBarrierBase::clear):
• jsc.cpp: (GlobalObject::GlobalObject): (functionReleaseExecutableMemory):
• runtime/Executable.cpp: (JSC::EvalExecutable::unlinkCalls): (JSC::ProgramExecutable::unlinkCalls): (JSC::FunctionExecutable::discardCode): (JSC::FunctionExecutable::unlinkCalls):
• runtime/Executable.h:
• runtime/JSGlobalData.cpp: (JSC::SafeRecompiler::returnValue): (JSC::SafeRecompiler::operator()): (JSC::JSGlobalData::releaseExecutableMemory):

File:

• trunk/Source/JavaScriptCore/bytecode/CodeBlock.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

@@ -99 +99 @@
         CallLinkInfo()
             : hasSeenShouldRepatch(false)
+            , isCall(false)
         {
         }
@@ -106 +107 @@
         CodeLocationNearCall hotPathOther;
         JITWriteBarrier<JSFunction> callee;
-        bool hasSeenShouldRepatch;
+        bool hasSeenShouldRepatch : 1;
+        bool isCall : 1;
 
         bool isLinked() { return callee; }
+        void unlink()
+        {
+            hasSeenShouldRepatch = false;
+            callee.clear();
+        }
 
         bool seenOnce()
@@ -271 +278 @@
             return binarySearch<CallReturnOffsetToBytecodeOffset, unsigned, getCallReturnOffset>(callIndices.begin(), callIndices.size(), getJITCode().offsetOf(returnAddress.value()))->bytecodeOffset;
         }
-#endif
+
+        void unlinkCalls();
+#endif
+
 #if ENABLE(INTERPRETER)
         unsigned bytecodeOffset(Instruction* returnAddress)
@@ -340 +350 @@
 
         void createActivation(CallFrame*);
+
+        void clearEvalCache();
 
 #if ENABLE(INTERPRETER)