Changeset 90157 in webkit for trunk/Source/JavaScriptCore/assembler/X86Assembler.h

Timestamp:

Jun 30, 2011, 2:30:57 PM (14 years ago)

Author:

[email protected]

Message:

2011-06-30 Filip Pizlo <​[email protected]>

Reviewed by Gavin Barraclough.

X86Assembler does not encode byte registers in 64-bit mode correctly.
​https://bugs.webkit.org/show_bug.cgi?id=63665

• assembler/X86Assembler.h: (JSC::X86Assembler::testb_rr): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):

File:

• trunk/Source/JavaScriptCore/assembler/X86Assembler.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/assembler/X86Assembler.h

@@ -880 +880 @@
     void testb_rr(RegisterID src, RegisterID dst)
     {
-        m_formatter.oneByteOp(OP_TEST_EbGb, src, dst);
+        m_formatter.oneByteOp8(OP_TEST_EbGb, src, dst);
     }
 
@@ -1869 +1869 @@
         }
 
+        void oneByteOp8(OneByteOpcodeID opcode, int reg, RegisterID rm)
+        {
+            m_buffer.ensureSpace(maxInstructionSize);
+            emitRexIf(byteRegRequiresRex(reg) || byteRegRequiresRex(rm), reg, 0, rm);
+            m_buffer.putByteUnchecked(opcode);
+            registerModRM(reg, rm);
+        }
+
         void twoByteOp8(TwoByteOpcodeID opcode, RegisterID reg, RegisterID rm)
         {