Changeset 90193 in webkit for trunk/Source/JavaScriptCore/jit/JSInterfaceJIT.h

Timestamp:

Jun 30, 2011, 7:17:27 PM (14 years ago)

Author:

[email protected]

Message:

2011-06-30 Geoffrey Garen <​[email protected]>

Reviewed by Gavin Barraclough.

Added write barrier that was missing from put_by_id_transition
​https://bugs.webkit.org/show_bug.cgi?id=63775

• dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::writeBarrier): Made this static with a MacroAssembler& argument so our patching functions could use it.

(JSC::DFG::JITCodeGenerator::cachedPutById):

• dfg/DFGJITCodeGenerator.h:
• dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile): Updated for signature change.

• dfg/DFGRepatch.cpp: (JSC::DFG::tryCachePutByID): Missing barrier!

• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile): Updated for signature change.

• jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
• jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePutByIdTransition):
• jit/JSInterfaceJIT.h: Same game here. Removed storePtrWithWriteBarrier because its meaning isn't clear -- maybe in the future we'll have a clear way to pass all stores through a common function that guarantees a write barrier, but that's not the case right now.

File:

• trunk/Source/JavaScriptCore/jit/JSInterfaceJIT.h (modified) (1 diff)

trunk/Source/JavaScriptCore/jit/JSInterfaceJIT.h

@@ -194 +194 @@
         inline Jump emitLoadDouble(unsigned virtualRegisterIndex, FPRegisterID dst, RegisterID scratch);
 
-        inline void storePtrWithWriteBarrier(TrustedImmPtr ptr, RegisterID /* owner */, Address dest)
-        {
-            storePtr(ptr, dest);
-        }
-
 #if USE(JSVALUE32_64)
         inline Jump emitJumpIfNotJSCell(unsigned virtualRegisterIndex);