Changeset 90215 in webkit for trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.h

Timestamp:

Jul 1, 2011, 12:47:55 AM (14 years ago)

Author:

[email protected]

Message:

2011-07-01 Sheriff Bot <​[email protected]>

Unreviewed, rolling out r90177 and r90179.
​http://trac.webkit.org/changeset/90177
​http://trac.webkit.org/changeset/90179
​https://bugs.webkit.org/show_bug.cgi?id=63790

It caused crashes on Qt in debug mode (Requested by Ossy on
#webkit).

• assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::sqrtDouble):
• assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::sqrtDouble):
• assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::sqrtDouble): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
• assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::sqrtDouble):
• assembler/MacroAssemblerX86.h:
• assembler/MacroAssemblerX86Common.h:
• assembler/MacroAssemblerX86_64.h:
• assembler/X86Assembler.h:
• create_hash_table:
• jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitLoadDouble):
• jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
• jit/ThunkGenerators.cpp:
• jit/ThunkGenerators.h:

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.h

@@ -180 +180 @@
         m_assembler.movs_r(dest, m_assembler.asr_r(dest, ARMRegisters::S0));
     }
-    
+
     void rshift32(TrustedImm32 imm, RegisterID dest)
     {
-        rshift32(dest, imm, dest);
-    }
-
-    void rshift32(RegisterID src, TrustedImm32 imm, RegisterID dest)
-    {
-        m_assembler.movs_r(dest, m_assembler.asr(src, imm.m_value & 0x1f));
+        m_assembler.movs_r(dest, m_assembler.asr(dest, imm.m_value & 0x1f));
     }
     
@@ -795 +790 @@
         return s_isVFPPresent;
     }
-    bool supportsDoubleBitops() const { return false; }
 
     void loadDouble(ImplicitAddress address, FPRegisterID dest)
@@ -861 +855 @@
     {
         m_assembler.vsqrt_f64_r(dest, src);
-    }
-    
-    void andnotDouble(FPRegisterID, FPRegisterID)
-    {
-        ASSERT_NOT_REACHED();
     }