Changeset 90215 in webkit for trunk/Source/JavaScriptCore/jit/SpecializedThunkJIT.h

Timestamp:

Jul 1, 2011, 12:47:55 AM (14 years ago)

Author:

[email protected]

Message:

2011-07-01 Sheriff Bot <​[email protected]>

Unreviewed, rolling out r90177 and r90179.
​http://trac.webkit.org/changeset/90177
​http://trac.webkit.org/changeset/90179
​https://bugs.webkit.org/show_bug.cgi?id=63790

It caused crashes on Qt in debug mode (Requested by Ossy on
#webkit).

• assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::sqrtDouble):
• assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::sqrtDouble):
• assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::sqrtDouble): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
• assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::sqrtDouble):
• assembler/MacroAssemblerX86.h:
• assembler/MacroAssemblerX86Common.h:
• assembler/MacroAssemblerX86_64.h:
• assembler/X86Assembler.h:
• create_hash_table:
• jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitLoadDouble):
• jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
• jit/ThunkGenerators.cpp:
• jit/ThunkGenerators.h:

File:

• trunk/Source/JavaScriptCore/jit/SpecializedThunkJIT.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/jit/SpecializedThunkJIT.h

@@ -128 +128 @@
             LinkBuffer patchBuffer(globalData, this, m_pool.get());
             patchBuffer.link(m_failures, CodeLocationLabel(fallback));
-            for (unsigned i = 0; i < m_calls.size(); i++)
-                patchBuffer.link(m_calls[i].first, m_calls[i].second);
             return patchBuffer.finalizeCode().m_code;
         }
-
-        // Assumes that the target function uses fpRegister0 as the first argument
-        // and return value. Like any sensible architecture would.
-        void callDoubleToDouble(FunctionPtr function)
-        {
-            m_calls.append(std::make_pair(call(), function));
-        }
-
+        
     private:
         int argumentToVirtualRegister(unsigned argument)
@@ -166 +157 @@
         RefPtr<ExecutablePool> m_pool;
         MacroAssembler::JumpList m_failures;
-        Vector<std::pair<Call, FunctionPtr> > m_calls;
     };