Changeset 90415 in webkit for trunk/Source/JavaScriptCore/API/JSBase.cpp

Timestamp:

Jul 5, 2011, 4:55:45 PM (14 years ago)

Author:

[email protected]

Message:

2011-07-05 Oliver Hunt <​[email protected]>

Don't throw out compiled code repeatedly
​https://bugs.webkit.org/show_bug.cgi?id=63960

Reviewed by Gavin Barraclough.

Stop throwing away all compiled code every time
we're told to do a full GC. Instead unlink all
callsites during such GC passes to maximise the
number of collectable functions, but otherwise
leave compiled functions alone.

• API/JSBase.cpp: (JSGarbageCollect):
• bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
• heap/Heap.cpp: (JSC::Heap::collectAllGarbage):
• heap/MarkStack.h: (JSC::MarkStack::shouldUnlinkCalls): (JSC::MarkStack::setShouldUnlinkCalls):
• runtime/JSGlobalData.cpp: (JSC::JSGlobalData::recompileAllJSFunctions): (JSC::JSGlobalData::releaseExecutableMemory):
• runtime/RegExp.cpp: (JSC::RegExp::compile): (JSC::RegExp::invalidateCode):
• runtime/RegExp.h:

File:

• trunk/Source/JavaScriptCore/API/JSBase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSBase.cpp

@@ -98 +98 @@
 
     JSGlobalData& globalData = exec->globalData();
-    if (!globalData.heap.isBusy())
-        globalData.heap.collectAllGarbage();
+    if (!globalData.heap.isBusy()) {
+        // releaseExecutableMemory forces a full GC
+        globalData.releaseExecutableMemory();
+    }
 
     // FIXME: Perhaps we should trigger a second mark and sweep