Changeset 90529 in webkit for trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

Timestamp:

Jul 6, 2011, 8:42:02 PM (14 years ago)

Author:

[email protected]

Message:

2011-07-06 Filip Pizlo <​[email protected]>

DFG JIT does not support method_check
​https://bugs.webkit.org/show_bug.cgi?id=63972

Reviewed by Gavin Barraclough.

• assembler/CodeLocation.h: (JSC::CodeLocationPossiblyNearCall::CodeLocationPossiblyNearCall):
• bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
• bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::MethodCallLinkInfo): (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
• dfg/DFGAliasTracker.h: (JSC::DFG::AliasTracker::recordGetMethod):
• dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
• dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedGetById): (JSC::DFG::JITCodeGenerator::cachedGetMethod):
• dfg/DFGJITCodeGenerator.h:
• dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
• dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addMethodGet): (JSC::DFG::JITCompiler::MethodGetRecord::MethodGetRecord):
• dfg/DFGNode.h: (JSC::DFG::Node::hasIdentifier):
• dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGRepatch.cpp: (JSC::DFG::dfgRepatchGetMethodFast): (JSC::DFG::tryCacheGetMethod): (JSC::DFG::dfgRepatchGetMethod):
• dfg/DFGRepatch.h:
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
• jit/JITWriteBarrier.h: (JSC::JITWriteBarrier::set):

File:

• trunk/Source/JavaScriptCore/bytecode/CodeBlock.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

@@ -130 +130 @@
     struct MethodCallLinkInfo {
         MethodCallLinkInfo()
+            : seen(false)
         {
         }
@@ -135 +136 @@
         bool seenOnce()
         {
-            ASSERT(!cachedStructure);
-            return cachedPrototypeStructure.isFlagged();
+            return seen;
         }
 
         void setSeen()
         {
-            ASSERT(!cachedStructure && !cachedPrototypeStructure);
-            // We use the values of cachedStructure & cachedPrototypeStructure to indicate the
-            // current state.
-            //     - In the initial state, both are null.
-            //     - Once this transition has been taken once, cachedStructure is
-            //       null and cachedPrototypeStructure is set to a nun-null value.
-            //     - Once the call is linked both structures are set to non-null values.
-            cachedPrototypeStructure.setFlagOnBarrier();
+            seen = true;
         }
 
@@ -156 +149 @@
         JITWriteBarrier<JSFunction> cachedFunction;
         JITWriteBarrier<JSObject> cachedPrototype;
+        bool seen;
     };