Changeset 910 in webkit for trunk/JavaScriptCore


Ignore:
Timestamp:
Mar 30, 2002, 10:48:51 PM (23 years ago)
Author:
mjs
Message:

Fixed Radar 2891272 (JavaScript crashes loading quicktime.com and
apple.com)

  • kjs/object.cpp: (ObjectImp::~ObjectImp): Don't call setGCAlloc on object internals pointed to, because they may have already been collected by the time this object is collected, and in that case we would corrupt the malloc arena.
  • Makefile.am: Make the stamp file depend on all the sources and headers so the framework gets rebuilt properly.
  • JavaScriptCore.pbproj/project.pbxproj: Some random numbers moved around. No idea what I really changed.
Location:
trunk/JavaScriptCore
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r903 r910  
     12002-03-30  Maciej Stachowiak  <[email protected]>
     2
     3        Fixed Radar 2891272 (JavaScript crashes loading quicktime.com and
     4        apple.com)
     5
     6        * kjs/object.cpp: (ObjectImp::~ObjectImp): Don't call setGCAlloc
     7        on object internals pointed to, because they may have already been
     8        collected by the time this object is collected, and in that case
     9        we would corrupt the malloc arena.
     10
     11        * Makefile.am: Make the stamp file depend on all the sources and
     12        headers so the framework gets rebuilt properly.
     13
     14        * JavaScriptCore.pbproj/project.pbxproj: Some random numbers moved
     15        around. No idea what I really changed.
     16
    1172002-03-30  Darin Adler  <[email protected]>
    218

  • trunk/JavaScriptCore/ChangeLog-2002-12-03

    r903 r910  
     12002-03-30  Maciej Stachowiak  <[email protected]>
     2
     3        Fixed Radar 2891272 (JavaScript crashes loading quicktime.com and
     4        apple.com)
     5
     6        * kjs/object.cpp: (ObjectImp::~ObjectImp): Don't call setGCAlloc
     7        on object internals pointed to, because they may have already been
     8        collected by the time this object is collected, and in that case
     9        we would corrupt the malloc arena.
     10
     11        * Makefile.am: Make the stamp file depend on all the sources and
     12        headers so the framework gets rebuilt properly.
     13
     14        * JavaScriptCore.pbproj/project.pbxproj: Some random numbers moved
     15        around. No idea what I really changed.
     16
    1172002-03-30  Darin Adler  <[email protected]>
    218

  • trunk/JavaScriptCore/ChangeLog-2003-10-25

    r903 r910  
     12002-03-30  Maciej Stachowiak  <[email protected]>
     2
     3        Fixed Radar 2891272 (JavaScript crashes loading quicktime.com and
     4        apple.com)
     5
     6        * kjs/object.cpp: (ObjectImp::~ObjectImp): Don't call setGCAlloc
     7        on object internals pointed to, because they may have already been
     8        collected by the time this object is collected, and in that case
     9        we would corrupt the malloc arena.
     10
     11        * Makefile.am: Make the stamp file depend on all the sources and
     12        headers so the framework gets rebuilt properly.
     13
     14        * JavaScriptCore.pbproj/project.pbxproj: Some random numbers moved
     15        around. No idea what I really changed.
     16
    1172002-03-30  Darin Adler  <[email protected]>
    218

  • trunk/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

    r902 r910  
    8282                                0867D69AFE84028FC02AAC07,
    8383                                034768DFFF38A50411DB9C8B,
    84                                 F692A8C802555BA201FF60F7,
    85                                 F692A8C902555BA201FF60F7,
    86                                 F692A8CA02555BA201FF60F7,
    8784                        );
    8885                        isa = PBXGroup;
    … …  
    322319                                F692A85E0255597D01FF60F7,
    323320                                F692A85F0255597D01FF60F7,
     321                                F692A8C802555BA201FF60F7,
     322                                F692A8C902555BA201FF60F7,
     323                                F692A8CA02555BA201FF60F7,
    324324                                F692A8610255597D01FF60F7,
    325325                                F692A8620255597D01FF60F7,

  • trunk/JavaScriptCore/Makefile.am

    r901 r910  
    1313CLEANFILES = $(BUILT_SOURCES)
    1414
    15 JavaScriptCore-stamp:
     15JavaScriptCore-stamp: kjs/*.cpp kjs/*.h
    1616        pbxbuild -buildstyle $(BUILDSTYLE)
    1717        touch JavaScriptCore-stamp

  • trunk/JavaScriptCore/kjs/object.cpp

    r798 r910  
    202202{
    203203  //fprintf(stderr,"ObjectImp::~ObjectImp %p\n",(void*)this);
     204#if 0 // Those could be already deleted. The collector ensures no order
     205      // ### Check if this leads to memory leaks....
    204206  if (_proto)
    205207    _proto->setGcAllowed();
    … …  
    208210  if (_scope)
    209211    _scope->setGcAllowed();
     212#endif
    210213  delete _prop;
    211214}
Note: See TracChangeset for help on using the changeset viewer.