Changeset 910 in webkit for trunk/JavaScriptCore/kjs/object.cpp

Timestamp:

Mar 30, 2002, 10:48:51 PM (23 years ago)

Author:

mjs

Message:

Fixed Radar 2891272 (JavaScript crashes loading quicktime.com and
apple.com)

• kjs/object.cpp: (ObjectImp::~ObjectImp): Don't call setGCAlloc on object internals pointed to, because they may have already been collected by the time this object is collected, and in that case we would corrupt the malloc arena.

• Makefile.am: Make the stamp file depend on all the sources and headers so the framework gets rebuilt properly.

• JavaScriptCore.pbproj/project.pbxproj: Some random numbers moved around. No idea what I really changed.

File:

• trunk/JavaScriptCore/kjs/object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/object.cpp

@@ -202 +202 @@
 {
   //fprintf(stderr,"ObjectImp::~ObjectImp %p\n",(void*)this);
+#if 0 // Those could be already deleted. The collector ensures no order
+      // ### Check if this leads to memory leaks....
   if (_proto)
     _proto->setGcAllowed();
@@ -208 +210 @@
   if (_scope)
     _scope->setGcAllowed();
+#endif
   delete _prop;
 }