Changeset 91380 in webkit for trunk/Source/JavaScriptCore/ChangeLog

Timestamp:

Jul 20, 2011, 11:21:44 AM (14 years ago)

Author:

[email protected]

Message:

currentThread is too slow!
​https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

• wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

• wtf/ThreadIdentifierDataPthreads.h:
• wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

File:

• trunk/Source/JavaScriptCore/ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-07-14  David Levin  <[email protected]>
+
+        currentThread is too slow!
+        https://bugs.webkit.org/show_bug.cgi?id=64577
+
+        Reviewed by Darin Adler and Dmitry Titov.
+
+        The problem is that currentThread results in a pthread_once call which always takes a lock.
+        With this change, currentThread is 10% faster than isMainThread in release mode and only
+        5% slower than isMainThread in debug.
+
+        * wtf/ThreadIdentifierDataPthreads.cpp:
+        (WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
+        which is no longer needed because this is called from initializeThreading().
+        (WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
+        intialization of the pthread key should already be done.
+        (WTF::ThreadIdentifierData::initialize): Ditto.
+        * wtf/ThreadIdentifierDataPthreads.h:
+        * wtf/ThreadingPthreads.cpp:
+        (WTF::initializeThreading): Acquire the pthread key here.
+
 2011-07-20  Mark Rowe  <[email protected]>