Changeset 91765 in webkit for trunk/Source/JavaScriptCore/runtime/JSONObject.cpp

Timestamp:

Jul 26, 2011, 10:53:40 AM (14 years ago)

Author:

[email protected]

Message:

JSON errors should be informative
​https://bugs.webkit.org/show_bug.cgi?id=63339

Source/JavaScriptCore:

Added error messages to the JSON Parser.

Patch by Juan C. Montemayor <​[email protected]> on 2011-07-26
Reviewed by Oliver Hunt.

• runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

• runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

• runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):

LayoutTests:

Updated expected test results.

Patch by Juan C. Montemayor <​[email protected]> on 2011-07-26
Reviewed by Oliver Hunt.

• fast/js/JSON-parse-expected.txt:
• platform/chromium/fast/js/JSON-parse-expected.txt: Added.

File:

• trunk/Source/JavaScriptCore/runtime/JSONObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSONObject.cpp

@@ -820 +820 @@
     JSValue unfiltered = jsonParser.tryLiteralParse();
     if (!unfiltered)
-        return throwVMError(exec, createSyntaxError(exec, "Unable to parse JSON string"));
+        return throwVMError(exec, createSyntaxError(exec, jsonParser.getErrorMessage()));
     
     if (exec->argumentCount() < 2)