Changeset 92046 in webkit for trunk/Source/JavaScriptCore/heap/Handle.h

Timestamp:

Jul 29, 2011, 7:49:45 PM (14 years ago)

Author:

[email protected]

Message:

JSC GC zombie support no longer works, and is likely no longer needed.
​https://bugs.webkit.org/show_bug.cgi?id=65404

Reviewed by Darin Adler.

This removes zombies, because they no longer work, are not tested, are
probably not needed, and are getting in the way of GC optimization
work.

• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/Handle.h:

(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):

• heap/HandleHeap.cpp:

(JSC::HandleHeap::isValidWeakNode):

• heap/Heap.cpp:

(JSC::Heap::destroy):
(JSC::Heap::collect):

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

• heap/MarkedBlock.h:

(JSC::MarkedBlock::clearMarks):

• interpreter/Register.h:

(JSC::Register::Register):
(JSC::Register::operator=):

• runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::append):
(JSC::ArgList::ArgList):

• runtime/JSCell.cpp:

(JSC::isZombie):

• runtime/JSCell.h:
• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):

• runtime/JSGlobalData.h:
• runtime/JSValue.h:
• runtime/JSValueInlineMethods.h:

(JSC::JSValue::JSValue):

• runtime/JSZombie.cpp: Removed.
• runtime/JSZombie.h: Removed.
• runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):

• wtf/Platform.h:

File:

• trunk/Source/JavaScriptCore/heap/Handle.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/heap/Handle.h

@@ -81 +81 @@
     T* operator->()
     {
-#if ENABLE(JSC_ZOMBIES)
-        ASSERT(!static_cast<const Base*>(this)->get() || !static_cast<const Base*>(this)->get()->isZombie());
-#endif
         return static_cast<Base*>(this)->get();
     }
     const T* operator->() const
     {
-#if ENABLE(JSC_ZOMBIES)
-        ASSERT(!static_cast<const Base*>(this)->get() || !static_cast<const Base*>(this)->get()->isZombie());
-#endif
         return static_cast<const Base*>(this)->get();
     }
@@ -96 +90 @@
     T* operator*()
     {
-#if ENABLE(JSC_ZOMBIES)
-        ASSERT(!static_cast<const Base*>(this)->get() || !static_cast<const Base*>(this)->get()->isZombie());
-#endif
         return static_cast<Base*>(this)->get();
     }
     const T* operator*() const
     {
-#if ENABLE(JSC_ZOMBIES)
-        ASSERT(!static_cast<const Base*>(this)->get() || !static_cast<const Base*>(this)->get()->isZombie());
-#endif
         return static_cast<const Base*>(this)->get();
     }
@@ -120 +108 @@
     JSValue jsValue() const
     {
-#if ENABLE(JSC_ZOMBIES)
-        ASSERT(!static_cast<const Base*>(this)->get() || !static_cast<const Base*>(this)->get().isZombie());
-#endif
         return static_cast<const Base*>(this)->get();
     }