Changeset 92154 in webkit for trunk/Source/JavaScriptCore/wtf/ThreadingPthreads.cpp

Timestamp:

Aug 1, 2011, 5:10:21 PM (14 years ago)

Author:

[email protected]

Message:

currentThread is too slow!
​https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

• wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

• wtf/ThreadIdentifierDataPthreads.h:
• wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

File:

• trunk/Source/JavaScriptCore/wtf/ThreadingPthreads.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/wtf/ThreadingPthreads.cpp

@@ -87 +87 @@
     threadMapMutex();
     initializeRandomNumberGenerator();
+    ThreadIdentifierData::initializeOnce();
     wtfThreadData();
 #if ENABLE(WTF_MULTIPLE_THREADS)