Changeset 92250 in webkit for trunk/Source/JavaScriptCore/runtime/Executable.h

Timestamp:

Aug 2, 2011, 5:41:11 PM (14 years ago)

Author:

[email protected]

Message:

Simplify JSFunction creation for functions written in JS
​https://bugs.webkit.org/show_bug.cgi?id=65422

Reviewed by Gavin Barraclough.

Remove hash lookups used to write name property and transition
function structure by caching the resultant structure and property
offset in JSGlobalObject. This doesn't impact performance, but
we can use this change to make other improvements later.

• runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):

• runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::FunctionExecutable::jsName):

• runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::namedFunctionStructure):
(JSC::JSGlobalObject::functionNameOffset):

File:

• trunk/Source/JavaScriptCore/runtime/Executable.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/runtime/Executable.h

@@ -227 +227 @@
 #if ENABLE(CODEBLOCK_SAMPLING)
             if (SamplingTool* sampler = globalData.interpreter->sampler())
-                sampler->notifyOfScope(*globalData, this);
+                sampler->notifyOfScope(globalData, this);
 #else
             UNUSED_PARAM(globalData);
@@ -479 +479 @@
 
         const Identifier& name() { return m_name; }
+        JSString* nameValue() const { return m_nameValue.get(); }
         size_t parameterCount() const { return m_parameters->size(); }
         unsigned capturedVariableCount() const { return m_numCapturedVariables; }
@@ -510 +511 @@
         OwnPtr<FunctionCodeBlock> m_codeBlockForConstruct;
         Identifier m_name;
+        WriteBarrier<JSString> m_nameValue;
         SharedSymbolTable* m_symbolTable;
     };