Changeset 92569 in webkit for trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

Timestamp:

Aug 6, 2011, 8:44:45 PM (14 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=65821
Don't form identifiers the first time a string is used as a property name.

Reviewed by Oliver Hunt.

This is a 1% win on SunSpider.

• dfg/DFGOperations.cpp:
  • Use fastGetOwnProperty.
• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• Use fastGetOwnProperty.

• runtime/JSCell.h:
• runtime/JSObject.h:

(JSC::JSCell::fastGetOwnProperty):

• Fast call to get a property without creating an identifier the first time.

• runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):

• Add interface to look up by either strinsg or identifiers.

• runtime/Structure.h:

(JSC::Structure::get):

• Add a get() call that takes a UString, not an Identifier.

• wtf/text/StringImpl.h:

(WTF::StringImpl::hasHash):

• Add a call to check if the has has been set (to detect the first use as a property name).

File:

• trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

@@ -211 +211 @@
                 return getByVal(exec, base, propertyAsUInt32);
         } else if (property.isString()) {
-            Identifier propertyName(exec, asString(property)->value(exec));
-            PropertySlot slot(base);
-            if (base->fastGetOwnPropertySlot(exec, propertyName, slot))
-                return JSValue::encode(slot.getValue(exec, propertyName));
+            if (JSValue result = base->fastGetOwnProperty(exec, asString(property)->value(exec)))
+                return JSValue::encode(result);
         }
     }