Ignore:
Timestamp:
Aug 10, 2011, 12:52:27 PM (14 years ago)
Author:
[email protected]
Message:

Make GC checks more aggressive in release builds
​https://bugs.webkit.org/show_bug.cgi?id=66001

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

  • heap/HandleHeap.cpp:

(JSC::HandleHeap::visitStrongHandles):
(JSC::HandleHeap::visitWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::isLiveNode):
(JSC::HandleHeap::isValidWeakNode):

Increase handle heap validation logic, and make some of
the crashes trigger in release builds as well as debug.

  • heap/HandleHeap.h:

(JSC::HandleHeap::allocate):
(JSC::HandleHeap::makeWeak):

Ditto

  • runtime/JSGlobalData.cpp:

(WTF::Recompiler::operator()):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren):

Fix GC bugs found while testing this patch

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Fix GC bugs found while testing increased validation logic

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWindowShell):

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):

  • bridge/objc/objc_instance.mm:
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

    r92250 r92788  
    350350    visitIfNeeded(visitor, &m_errorStructure);
    351351    visitIfNeeded(visitor, &m_functionStructure);
     352    visitIfNeeded(visitor, &m_namedFunctionStructure);
    352353    visitIfNeeded(visitor, &m_numberObjectStructure);
    353354    visitIfNeeded(visitor, &m_regExpMatchesArrayStructure);
Note: See TracChangeset for help on using the changeset viewer.