Changeset 93059 in webkit for trunk/Source/JavaScriptGlue/JSRun.cpp

Timestamp:

Aug 15, 2011, 2:12:11 PM (14 years ago)

Author:

[email protected]

Message:

Refactor JS objects to allocate in static create methods rather than constructors
​https://bugs.webkit.org/show_bug.cgi?id=65347

Patch by Mark Hahnenberg <​[email protected]> on 2011-08-15
Reviewed by Geoffrey Garen.

Source/JavaScriptGlue:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

• JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

• JSRun.h:

(JSGlueGlobalObject::create):

Source/WebCore:

No new tests.

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

• bindings/js/JSDOMBinding.h:
• bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):

• bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

• bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):

• bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):

• bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):

• bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::create):

• bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

• bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

• bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::create):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

• bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::create):
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

• bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):

• bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::create):

• bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

• bridge/runtime_array.h:

(JSC::RuntimeArray::create):

• bridge/runtime_object.cpp:

Source/WebKit/mac:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

• Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):

File:

• trunk/Source/JavaScriptGlue/JSRun.cpp (modified) (1 diff)

trunk/Source/JavaScriptGlue/JSRun.cpp

@@ -34 +34 @@
 #include <JavaScriptCore/SourceCode.h>
 
-JSGlueGlobalObject::JSGlueGlobalObject(JSGlobalData& globalData, Structure* structure, JSFlags flags)
+JSGlueGlobalObject::JSGlueGlobalObject(JSGlobalData& globalData, Structure* structure, Structure* userObjectStructure, JSFlags flags)
     : JSGlobalObject(globalData, structure)
     , m_flags(flags)
-    , m_userObjectStructure(globalData, UserObjectImp::createStructure(globalData, jsNull()))
+    , m_userObjectStructure(globalData, userObjectStructure)
 {
 }