Changeset 93070 in webkit for trunk/Source/JavaScriptCore/dfg/DFGOperations.h

Timestamp:

Aug 15, 2011, 4:44:41 PM (14 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

Reviewed by Sam Weinig.

Source/JavaScriptCore:

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
  • Change bool return values to a 64-bit type.

LayoutTests:

• fast/js/kde/script-tests/operators.js:

(nonSpeculativeNotInner):
(nonSpeculativeNot):
(nonSpeculativeLessInner):
(nonSpeculativeLess):
(nonSpeculativeLessEqInner):
(nonSpeculativeLessEq):
(nonSpeculativeGreaterInner):
(nonSpeculativeGreater):
(nonSpeculativeGreaterEqInner):
(nonSpeculativeGreaterEq):
(nonSpeculativeEqualInner):
(nonSpeculativeEqual):
(nonSpeculativeNotEqualInner):
(nonSpeculativeNotEqual):
(nonSpeculativeStrictEqualInner):
(nonSpeculativeStrictEqual):
(nonSpeculativeStrictNotEqualInner):
(nonSpeculativeStrictNotEqual):

• Add tests cases that will hit the non-spec path.

File:

• trunk/Source/JavaScriptCore/dfg/DFGOperations.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/dfg/DFGOperations.h

@@ -35 +35 @@
 enum PutKind { Direct, NotDirect };
 
+typedef intptr_t RegisterSizedBoolean;
+
 extern "C" {
 
@@ -45 +47 @@
 typedef EncodedJSValue (*J_DFGOperation_EP)(ExecState*, void*);
 typedef EncodedJSValue (*J_DFGOperation_EI)(ExecState*, Identifier*);
-typedef bool (*Z_DFGOperation_EJ)(ExecState*, EncodedJSValue);
-typedef bool (*Z_DFGOperation_EJJ)(ExecState*, EncodedJSValue, EncodedJSValue);
+typedef RegisterSizedBoolean (*Z_DFGOperation_EJ)(ExecState*, EncodedJSValue);
+typedef RegisterSizedBoolean (*Z_DFGOperation_EJJ)(ExecState*, EncodedJSValue, EncodedJSValue);
 typedef void (*V_DFGOperation_EJJJ)(ExecState*, EncodedJSValue, EncodedJSValue, EncodedJSValue);
 typedef void (*V_DFGOperation_EJJP)(ExecState*, EncodedJSValue, EncodedJSValue, void*);
@@ -83 +85 @@
 void operationPutByIdDirectStrictOptimize(ExecState*, EncodedJSValue encodedValue, EncodedJSValue encodedBase, Identifier*);
 void operationPutByIdDirectNonStrictOptimize(ExecState*, EncodedJSValue encodedValue, EncodedJSValue encodedBase, Identifier*);
-bool operationCompareLess(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
-bool operationCompareLessEq(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
-bool operationCompareGreater(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
-bool operationCompareGreaterEq(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
-bool operationCompareEq(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
-bool operationCompareStrictEqCell(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
-bool operationCompareStrictEq(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
+RegisterSizedBoolean operationCompareLess(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
+RegisterSizedBoolean operationCompareLessEq(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
+RegisterSizedBoolean operationCompareGreater(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
+RegisterSizedBoolean operationCompareGreaterEq(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
+RegisterSizedBoolean operationCompareEq(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
+RegisterSizedBoolean operationCompareStrictEqCell(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
+RegisterSizedBoolean operationCompareStrictEq(ExecState*, EncodedJSValue encodedOp1, EncodedJSValue encodedOp2);
 void* operationVirtualCall(ExecState*);
 void* operationLinkCall(ExecState*);
@@ -112 +114 @@
 double dfgConvertJSValueToNumber(ExecState*, EncodedJSValue);
 int32_t dfgConvertJSValueToInt32(ExecState*, EncodedJSValue);
-bool dfgConvertJSValueToBoolean(ExecState*, EncodedJSValue);
+RegisterSizedBoolean dfgConvertJSValueToBoolean(ExecState*, EncodedJSValue);
 
 } // extern "C"