Changeset 93918 in webkit for trunk/Source/JavaScriptCore/heap/MarkStack.cpp

Timestamp:

Aug 26, 2011, 3:23:43 PM (14 years ago)

Author:

[email protected]

Message:

The GC does not have a facility for profiling the kinds of objects
that occupy the heap
​https://bugs.webkit.org/show_bug.cgi?id=66849

Reviewed by Geoffrey Garen.

Destructor calls and object scans are now optionally counted, per
vtable. When the heap is destroyed and profiling is enabled, the
counts are dumped, with care taken to print the names of classes
(modulo C++ mangling) sorted in descending commonality.

• GNUmakefile.list.am:
• JavaScriptCore.exp:
• JavaScriptCore.pro:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/Heap.cpp:

(JSC::Heap::destroy):

• heap/Heap.h:
• heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):

• heap/MarkStack.h:
• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor):

• heap/MarkedBlock.h:
• heap/VTableSpectrum.cpp: Added.

(JSC::VTableSpectrum::VTableSpectrum):
(JSC::VTableSpectrum::~VTableSpectrum):
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::count):
(JSC::VTableAndCount::VTableAndCount):
(JSC::VTableAndCount::operator<):
(JSC::VTableSpectrum::dump):

• heap/VTableSpectrum.h: Added.
• wtf/Platform.h:

File:

• trunk/Source/JavaScriptCore/heap/MarkStack.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/heap/MarkStack.cpp

@@ -54 +54 @@
 inline void SlotVisitor::visitChildren(JSCell* cell)
 {
+#if ENABLE(SIMPLE_HEAP_PROFILING)
+    m_visitedTypeCounts.count(cell);
+#endif
+
     ASSERT(Heap::isMarked(cell));
     if (cell->structure()->typeInfo().type() < CompoundType) {
@@ -109 +113 @@
 
             if (cell->structure()->typeInfo().type() < CompoundType) {
+#if ENABLE(SIMPLE_HEAP_PROFILING)
+                m_visitedTypeCounts.count(cell);
+#endif
                 cell->JSCell::visitChildren(*this);
                 if (current.m_values == end) {