Changeset 9404 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Jun 16, 2005, 5:57:37 PM (20 years ago)

Author:

ggaren

Message:

Fixed: <rdar://problem/4151759> 'delete' fails on variables declared inside 'eval' statements.

Reviewed by cblu.

• kjs/context.h: (KJS::ContextImp::codeType): Added code type accessor for execution context objects.
• kjs/internal.cpp: (ContextImp::ContextImp): Reflects change to ContextImp::codeType.
• kjs/nodes.cpp: (VarDeclNode::evaluate): Added separate code path for variable declarations inside 'eval' statements.
• tests/mozilla/expected.html: Updated expected test results to reflect fix.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -1629 +1629 @@
   // We use Internal to bypass all checks in derived objects, e.g. so that
   // "var location" creates a dynamic property instead of activating window.location.
-  variable.put(exec, ident, val, DontDelete | Internal);
-
+  if (exec->context().imp()->codeType() == EvalCode) {
+      // ECMA 10.2.2
+      variable.put(exec, ident, val, Internal); 
+  } else {
+      variable.put(exec, ident, val, DontDelete | Internal);
+  }
   return ident.ustring();
 }