Changeset 94336 in webkit for trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

Timestamp:

Sep 1, 2011, 1:04:34 PM (14 years ago)

Author:

[email protected]

Message:

Remove simple usage of UString::characters() from JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=67340

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Most of the changes below
change s->characters()[0] to s[0].

Reviewed by Geoffrey Garen.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::keyForCharacterSwitch):

• bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• runtime/Identifier.cpp:

(JSC::Identifier::addSlowCase):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::jsToNumber):
(JSC::parseFloat):

• runtime/JSString.cpp:

(JSC::JSString::substringFromRope):

• runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):

• runtime/RegExp.cpp:

(JSC::regExpFlags):

• wtf/text/StringBuilder.h:

(WTF::StringBuilder::operator[]):

File:

• trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

@@ -368 +368 @@
 
     if (size == 1) {
-        UChar c = s.characters()[0];
+        UChar c = s[0];
         if (isASCIIDigit(c))
             return c - '0';
@@ -411 +411 @@
 
     if (size == 1) {
-        UChar c = s.characters()[0];
+        UChar c = s[0];
         if (isASCIIDigit(c))
             return c - '0';