Changeset 9448 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Jun 21, 2005, 11:42:30 AM (20 years ago)

Author:

ggaren

Message:

• fixed <rdar://problem/4155532> 'delete' succeeds on functions
• fixed <rdar://problem/4155049> javascript function named as "opener" doesn't get called because of window.opener property

Reviewed by cblu.

• kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): Functions now have DontDelete and Internal attributes set when appropriate.

Test cases:

• tests/mozilla/expected.html: Updated for one new success.
• see also test case added in WebCore.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -2780 +2780 @@
   func.put(exec, lengthPropertyName, Number(plen), ReadOnly|DontDelete|DontEnum);
 
-  exec->context().imp()->variableObject().put(exec,ident,func);
+  if (exec->context().imp()->codeType() == EvalCode) {
+    // ECMA 10.2.2
+    exec->context().imp()->variableObject().put(exec, ident, func, Internal);
+  } else {
+    exec->context().imp()->variableObject().put(exec, ident, func, Internal | DontDelete);
+  }
 
   if (body) {