Changeset 94814 in webkit for trunk/Source/JavaScriptCore/heap/Heap.h

Timestamp:

Sep 8, 2011, 3:52:04 PM (14 years ago)

Author:

[email protected]

Message:

Use bump allocator for initial property storage
​https://bugs.webkit.org/show_bug.cgi?id=67494

Reviewed by Geoffrey Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Use a bump allocator for initial allocation of property storage,
and promote to fastMalloc memory only if it survives a GC pass.

Comes out as a 1% win on v8, and is a useful step on the way to
GC allocation of all property storage.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/Heap.cpp:

(JSC::Heap::collect):

• heap/Heap.h:

(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursery):

• heap/MarkedBlock.h:
• heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

• heap/NewSpace.h:

(JSC::NewSpace::resetPropertyStorageNursery):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursery):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

• runtime/JSObject.h:

(JSC::JSObject::isUsingInlineStorage):
(JSC::JSObject::JSObject):
(JSC::JSObject::propertyStorage):
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

• runtime/StorageBarrier.h: Added.

(JSC::StorageBarrier::StorageBarrier):
(JSC::StorageBarrier::set):
(JSC::StorageBarrier::operator->):
(JSC::StorageBarrier::operator*):
(JSC::StorageBarrier::operator[]):
(JSC::StorageBarrier::get):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header.

• ForwardingHeaders/runtime/StorageBarrier.h: Added.

File:

• trunk/Source/JavaScriptCore/heap/Heap.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/heap/Heap.h

@@ -92 +92 @@
         void collectAllGarbage();
 
+        inline void* allocatePropertyStorage(size_t);
+        inline bool inPropertyStorageNursery(void*);
+
         void reportExtraMemoryCost(size_t cost);
 
@@ -164 +167 @@
 
         static void writeBarrierSlowCase(const JSCell*, JSCell*);
-        
+
 #if ENABLE(LAZY_BLOCK_FREEING)
         void waitForRelativeTimeWhileHoldingLock(double relative);
@@ -360 +363 @@
     }
 
+    inline void* Heap::allocatePropertyStorage(size_t bytes)
+    {
+        ASSERT(!(bytes % sizeof(JSValue)));
+        if (bytes >= NewSpace::PropertyStorageNurserySize)
+            return 0;
+        if (void* result = m_newSpace.allocatePropertyStorage(bytes))
+            return result;
+        collect(DoNotSweep);
+        return m_newSpace.allocatePropertyStorage(bytes);
+    }
+    
+    inline bool Heap::inPropertyStorageNursery(void* ptr)
+    {
+        return m_newSpace.inPropertyStorageNursery(ptr);
+    }
+
 } // namespace JSC