Changeset 94814 in webkit for trunk/Source/JavaScriptCore/heap/NewSpace.h

Timestamp:

Sep 8, 2011, 3:52:04 PM (14 years ago)

Author:

[email protected]

Message:

Use bump allocator for initial property storage
​https://bugs.webkit.org/show_bug.cgi?id=67494

Reviewed by Geoffrey Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Use a bump allocator for initial allocation of property storage,
and promote to fastMalloc memory only if it survives a GC pass.

Comes out as a 1% win on v8, and is a useful step on the way to
GC allocation of all property storage.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/Heap.cpp:

(JSC::Heap::collect):

• heap/Heap.h:

(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursery):

• heap/MarkedBlock.h:
• heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

• heap/NewSpace.h:

(JSC::NewSpace::resetPropertyStorageNursery):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursery):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

• runtime/JSObject.h:

(JSC::JSObject::isUsingInlineStorage):
(JSC::JSObject::JSObject):
(JSC::JSObject::propertyStorage):
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

• runtime/StorageBarrier.h: Added.

(JSC::StorageBarrier::StorageBarrier):
(JSC::StorageBarrier::set):
(JSC::StorageBarrier::operator->):
(JSC::StorageBarrier::operator*):
(JSC::StorageBarrier::operator[]):
(JSC::StorageBarrier::get):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header.

• ForwardingHeaders/runtime/StorageBarrier.h: Added.

File:

• trunk/Source/JavaScriptCore/heap/NewSpace.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/heap/NewSpace.h

@@ -47 +47 @@
     public:
         static const size_t maxCellSize = 1024;
+        static const size_t PropertyStorageNurserySize = 4 * MB;
 
         struct SizeClass {
@@ -64 +65 @@
         SizeClass& sizeClassFor(size_t);
         void* allocate(SizeClass&);
+        inline void* allocatePropertyStorage(size_t);
+        inline bool inPropertyStorageNursery(void* ptr);
+        inline void resetPropertyStorageNursery();
+        
         void resetAllocator();
 
@@ -92 +97 @@
         SizeClass m_preciseSizeClasses[preciseCount];
         SizeClass m_impreciseSizeClasses[impreciseCount];
+        char* m_propertyStorageNursery;
+        char* m_propertyStorageAllocationPoint;
         size_t m_waterMark;
         size_t m_highWaterMark;
@@ -161 +168 @@
     }
 
+    inline void NewSpace::resetPropertyStorageNursery()
+    {
+        m_propertyStorageAllocationPoint = m_propertyStorageNursery;
+    }
+    
+    inline void* NewSpace::allocatePropertyStorage(size_t size)
+    {
+        char* result = m_propertyStorageAllocationPoint;
+        if (size > PropertyStorageNurserySize)
+            CRASH();
+        m_propertyStorageAllocationPoint += size;
+        if (static_cast<size_t>(m_propertyStorageAllocationPoint - m_propertyStorageNursery) > PropertyStorageNurserySize) {
+            m_propertyStorageAllocationPoint = result;
+            return 0;
+        }
+        return result;
+    }
+
+    inline bool NewSpace::inPropertyStorageNursery(void* ptr)
+    {
+        char* addr = static_cast<char*>(ptr);
+        return static_cast<size_t>(addr - m_propertyStorageNursery) < PropertyStorageNurserySize;
+    }
+    
     template <typename Functor> inline typename Functor::ReturnType NewSpace::forEachBlock(Functor& functor)
     {