Changeset 94931 in webkit for trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h

Timestamp:

Sep 11, 2011, 3:29:24 PM (14 years ago)

Author:

[email protected]

Message:

De-virtualize JSCell::isAPIValueWrapper
​https://bugs.webkit.org/show_bug.cgi?id=67909

Reviewed by Oliver Hunt.

• runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):
Set the correct type on structure creation.

• runtime/JSCell.h:

Remove virtual keyword and default implementation.

• runtime/JSType.h:

Add type for APIValueWrapper. It must come after CompoundType since
the APIValueWrapper has children in need of marking.

• runtime/Structure.h:

(JSC::JSCell::isAPIValueWrapper):
Implement predicate using type info.

File:

• trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h

@@ -38 +38 @@
         JSValue value() const { return m_value.get(); }
 
-        virtual bool isAPIValueWrapper() const { return true; }
-
         static Structure* createStructure(JSGlobalData& globalData, JSGlobalObject* globalObject, JSValue prototype)
         {
-            return Structure::create(globalData, globalObject, prototype, TypeInfo(CompoundType, OverridesVisitChildren | OverridesGetPropertyNames), &s_info);
+            return Structure::create(globalData, globalObject, prototype, TypeInfo(APIValueWrapper, OverridesVisitChildren | OverridesGetPropertyNames), &s_info);
         }