Changeset 95167 in webkit for trunk/Source/JavaScriptCore/JavaScriptCore.exp

Timestamp:

Sep 14, 2011, 10:15:16 PM (14 years ago)

Author:

[email protected]

Message:

Make JSCell::toBoolean non-virtual
​https://bugs.webkit.org/show_bug.cgi?id=67727

Reviewed by Sam Weinig.

JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• runtime/JSCell.cpp:
• runtime/JSCell.h:
• runtime/JSNotAnObject.cpp:
• runtime/JSNotAnObject.h:
• runtime/JSObject.h:
• runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

• runtime/StringObjectThatMasqueradesAsUndefined.h:

File:

• trunk/Source/JavaScriptCore/JavaScriptCore.exp (modified) (2 diffs)

trunk/Source/JavaScriptCore/JavaScriptCore.exp

@@ -564 +564 @@
 __ZNK3JSC6JSCell9getStringEPNS_9ExecStateE
 __ZNK3JSC6JSCell9getStringEPNS_9ExecStateERNS_7UStringE
-__ZNK3JSC6JSCell9toBooleanEPNS_9ExecStateE
 __ZNK3JSC7ArgList8getSliceEiRS0_
 __ZNK3JSC7JSArray12subclassDataEv
@@ -586 +585 @@
 __ZNK3JSC8JSObject9toBooleanEPNS_9ExecStateE
 __ZNK3JSC8JSString11resolveRopeEPNS_9ExecStateE
+__ZNK3JSC8JSString9toBooleanEPNS_9ExecStateE
 __ZNK3JSC9HashTable11createTableEPNS_12JSGlobalDataE
 __ZNK3JSC9HashTable11deleteTableEv