Changeset 95877 in webkit for trunk/Source/JavaScriptCore/parser/SourceProviderCacheItem.h

Timestamp:

Sep 23, 2011, 3:59:18 PM (14 years ago)

Author:

[email protected]

Message:

Source/JavaScriptCore: Strict mode does not work in non-trivial nested functions.
​https://bugs.webkit.org/show_bug.cgi?id=68740

Reviewed by Oliver Hunt.

Function-info caching does not preserve all state that it should.

• parser/JSParser.cpp:

(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::parseFunctionInfo):

• parser/SourceProviderCacheItem.h:

LayoutTests: ​[email protected]>

Strict mode does not work in non-trivial nested functions.
​https://bugs.webkit.org/show_bug.cgi?id=68740

Reviewed by Oliver Hunt.

Function-info caching does not preserve all state that it should.

• fast/js/nested-functions-expected.txt: Added.
• fast/js/nested-functions.html: Added.
• fast/js/script-tests/nested-functions.js: Added.

(runTests.test1):
(runTests.test2):
(runTests.test3):
(runTests):

File:

• trunk/Source/JavaScriptCore/parser/SourceProviderCacheItem.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/SourceProviderCacheItem.h

@@ -60 +60 @@
     int closeBracePos;
     bool usesEval;
+    bool strictMode;
+    bool needsFullActivation;
     Vector<RefPtr<StringImpl> > usedVariables;
     Vector<RefPtr<StringImpl> > writtenVariables;