Changeset 96045 in webkit for trunk/Source/JavaScriptCore/runtime/JSNotAnObject.cpp

Timestamp:

Sep 26, 2011, 4:53:42 PM (14 years ago)

Author:

[email protected]

Message:

Make JSCell::toBoolean non-virtual
​https://bugs.webkit.org/show_bug.cgi?id=67727

Reviewed by Geoffrey Garen.

JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• runtime/JSCell.cpp:
• runtime/JSCell.h:
• runtime/JSNotAnObject.cpp:
• runtime/JSNotAnObject.h:
• runtime/JSObject.h:
• runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

File:

• trunk/Source/JavaScriptCore/runtime/JSNotAnObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSNotAnObject.cpp

@@ -45 +45 @@
 
 bool JSNotAnObject::getPrimitiveNumber(ExecState* exec, double&, JSValue&)
-{
-    ASSERT_UNUSED(exec, exec->hadException());
-    return false;
-}
-
-bool JSNotAnObject::toBoolean(ExecState* exec) const
 {
     ASSERT_UNUSED(exec, exec->hadException());