Changeset 96381 in webkit for trunk/Source/JavaScriptCore/runtime/JSCell.cpp

Timestamp:

Sep 29, 2011, 7:09:16 PM (14 years ago)

Author:

[email protected]

Message:

De-virtualize JSCell::toObject
​https://bugs.webkit.org/show_bug.cgi?id=68937

Reviewed by Darin Adler.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

De-virtualized JSCell::toObject and changed its implementation to manually check the
cases for JSString and JSObject rather than leaving it up to the virtual method call.

• runtime/JSCell.cpp:

(JSC::JSCell::toObject):

• runtime/JSCell.h:

Removed JSNotAnObject::toObject because the case for JSObject works for it.
Also removed JSObject::toObject because it was essentially the identity function,
which is not necessary since toObject is no longer virtual.

• runtime/JSNotAnObject.cpp:
• runtime/JSNotAnObject.h:
• runtime/JSObject.cpp:
• runtime/JSObject.h:

De-virtualized JSObject::toObject and JSString::toObject.

• runtime/JSString.h:

File:

• trunk/Source/JavaScriptCore/runtime/JSCell.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSCell.cpp

@@ -152 +152 @@
 }
 
-JSObject* JSCell::toObject(ExecState*, JSGlobalObject*) const
+JSObject* JSCell::toObject(ExecState* exec, JSGlobalObject* globalObject) const
 {
-    ASSERT_NOT_REACHED();
-    return 0;
+    if (isString())
+        return static_cast<const JSString*>(this)->toObject(exec, globalObject);
+    ASSERT(isObject());
+    return static_cast<JSObject*>(const_cast<JSCell*>(this));
 }