Changeset 96381 in webkit for trunk/Source/JavaScriptCore/runtime/JSString.h

Timestamp:

Sep 29, 2011, 7:09:16 PM (14 years ago)

Author:

[email protected]

Message:

De-virtualize JSCell::toObject
​https://bugs.webkit.org/show_bug.cgi?id=68937

Reviewed by Darin Adler.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

De-virtualized JSCell::toObject and changed its implementation to manually check the
cases for JSString and JSObject rather than leaving it up to the virtual method call.

• runtime/JSCell.cpp:

(JSC::JSCell::toObject):

• runtime/JSCell.h:

Removed JSNotAnObject::toObject because the case for JSObject works for it.
Also removed JSObject::toObject because it was essentially the identity function,
which is not necessary since toObject is no longer virtual.

• runtime/JSNotAnObject.cpp:
• runtime/JSNotAnObject.h:
• runtime/JSObject.cpp:
• runtime/JSObject.h:

De-virtualized JSObject::toObject and JSString::toObject.

• runtime/JSString.h:

File:

• trunk/Source/JavaScriptCore/runtime/JSString.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSString.h

@@ -430 +430 @@
         bool toBoolean(ExecState*) const;
         bool getPrimitiveNumber(ExecState*, double& number, JSValue&) const;
+        JSObject* toObject(ExecState*, JSGlobalObject*) const;
         
         bool getStringPropertySlot(ExecState*, const Identifier& propertyName, PropertySlot&);
@@ -498 +499 @@
 
         virtual double toNumber(ExecState*) const;
-        virtual JSObject* toObject(ExecState*, JSGlobalObject*) const;
         virtual UString toString(ExecState*) const;