Changeset 96595 in webkit for trunk/Source/JavaScriptCore/wtf/Assertions.cpp

Timestamp:

Oct 4, 2011, 8:39:46 AM (14 years ago)

Author:

[email protected]

Message:

add more stack dumping methods
​https://bugs.webkit.org/show_bug.cgi?id=69018

In addition to WTFReportBacktrace, this adds the cross-platform WTFGetBacktrace, which lets
WebKit programmatically retrieve the current stack. This is useful if you need to add more
reporting to field crash report uploads, if you're tracking down an irreproducable bug,
for instance.

Reviewed by Darin Adler.

• wtf/Assertions.cpp:
• wtf/Assertions.h:

File:

• trunk/Source/JavaScriptCore/wtf/Assertions.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/wtf/Assertions.cpp

@@ -50 +50 @@
 #endif
 
-#if PLATFORM(MAC)
+#if OS(DARWIN) || OS(LINUX)
 #include <cxxabi.h>
 #include <dlfcn.h>
@@ -167 +167 @@
 }
 
+void WTFGetBacktrace(void** stack, int* size)
+{
+#if OS(DARWIN) || OS(LINUX)
+    *size = backtrace(stack, *size);
+#elif OS(WINDOWS)
+    // The CaptureStackBackTrace function is available in XP, but it is not defined
+    // in the Windows Server 2003 R2 Platform SDK. So, we'll grab the function
+    // through GetProcAddress.
+    typedef WORD (NTAPI* RtlCaptureStackBackTraceFunc)(DWORD, DWORD, PVOID*, PDWORD);
+    HMODULE kernel32 = ::GetModuleHandleW(L"Kernel32.dll");
+    if (!kernel32) {
+        *size = 0;
+        return;
+    }
+    RtlCaptureStackBackTraceFunc captureStackBackTraceFunc = reinterpret_cast<RtlCaptureStackBackTraceFunc>(
+        ::GetProcAddress(kernel32, "RtlCaptureStackBackTrace"));
+    if (captureStackBackTraceFunc)
+        *size = captureStackBackTraceFunc(1, *size, stack, 0);
+    else
+        *size = 0;
+#else
+    *size = 0;
+#endif
+}
+
 void WTFReportBacktrace()
 {
-#if PLATFORM(MAC)
     static const int maxFrames = 32;
     void* samples[maxFrames];
-    int frames = backtrace(samples, maxFrames);
+    int frames = maxFrames;
+
+    WTFGetBacktrace(samples, &frames);
 
     for (int i = 1; i < frames; ++i) {
-        void* pointer = samples[i];
-
-        // Try to get a symbol name from the dynamic linker.
+        const char* mangledName = 0;
+        char* cxaDemangled = 0;
+
+#if !PLATFORM(QT) && (OS(DARWIN) || OS(LINUX))
         Dl_info info;
-        if (dladdr(pointer, &info) && info.dli_sname) {
-            const char* mangledName = info.dli_sname;
-
-            // Assume c++ & try to demangle the name.
-            char* demangledName = abi::__cxa_demangle(mangledName, 0, 0, 0);
-            if (demangledName) {
-                fprintf(stderr, "%-3d %s\n", i, demangledName);
-                free(demangledName);
-            } else
-                fprintf(stderr, "%-3d %s\n", i, mangledName);
-        } else
-            fprintf(stderr, "%-3d %p\n", i, pointer);
-    }
-#endif
+        if (dladdr(samples[i], &info) && info.dli_sname)
+            mangledName = info.dli_sname;
+        if (mangledName)
+            cxaDemangled = abi::__cxa_demangle(mangledName, 0, 0, 0);
+#endif
+        if (mangledName || cxaDemangled)
+            fprintf(stderr, "%-3d %p %s\n", i, samples[i], cxaDemangled ? cxaDemangled : mangledName);
+        else
+            fprintf(stderr, "%-3d %p\n", i, samples[i]);
+        free(cxaDemangled);
+    }
 }