Changeset 96627 in webkit for trunk/Source/JavaScriptCore/API/JSClassRef.cpp

Timestamp:

Oct 4, 2011, 12:02:03 PM (14 years ago)

Author:

[email protected]

Message:

Implicitly add toString and valueOf to prototype when convertToType callback is provided
​https://bugs.webkit.org/show_bug.cgi?id=69156

Reviewed by Geoffrey Garen.

Added callbacks for toString and valueOf which are implicitly added to a client object's
prototype if they provide a convertToType callback when declaring their class through
the JSC API.

• API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):

• API/JSCallbackFunction.h:
• API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

• API/tests/testapi.js:

File:

• trunk/Source/JavaScriptCore/API/JSClassRef.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSClassRef.cpp

@@ -244 +244 @@
      *  DerivedClass  |  DerivedClassPrototype
      */
-    
+
+    if (convertToType) {
+        if (!prototypeClass)
+            prototypeClass = OpaqueJSClass::create(&kJSClassDefinitionEmpty).leakRef();
+        if (!prototypeClass->m_staticFunctions)
+            prototypeClass->m_staticFunctions = new OpaqueJSClassStaticFunctionsTable;
+        const Identifier& toString = exec->propertyNames().toString;
+        const Identifier& valueOf = exec->propertyNames().valueOf;
+        prototypeClass->m_staticFunctions->add(StringImpl::create(toString.characters(), toString.length()), new StaticFunctionEntry(&JSCallbackFunction::toStringCallback, 0));
+        prototypeClass->m_staticFunctions->add(StringImpl::create(valueOf.characters(), valueOf.length()), new StaticFunctionEntry(&JSCallbackFunction::valueOfCallback, 0));
+    }
+
     if (!prototypeClass)
         return 0;