Changeset 96717 in webkit for trunk/Source/JavaScriptCore/jit/JITStubs.cpp

Timestamp:

Oct 5, 2011, 9:52:16 AM (14 years ago)

Author:

[email protected]

Message:

Removed JSValue::toJSNumber
​https://bugs.webkit.org/show_bug.cgi?id=69399

No perf. change.

toJSNumber() used to provide an implicit fast path for immediate numbers,
but those fast paths are all explicit now, so it's just cruft.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• runtime/JSValue.h:
• runtime/JSValueInlineMethods.h:

File:

• trunk/Source/JavaScriptCore/jit/JITStubs.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/jit/JITStubs.cpp

@@ -3050 +3050 @@
     CallFrame* callFrame = stackFrame.callFrame;
 
-    JSValue number = v.toJSNumber(callFrame);
-    CHECK_FOR_EXCEPTION_AT_END();
-
-    callFrame->registers()[stackFrame.args[1].int32()] = jsNumber(number.asNumber() + 1);
-    return JSValue::encode(number);
+    double number = v.toNumber(callFrame);
+    CHECK_FOR_EXCEPTION_AT_END();
+
+    callFrame->registers()[stackFrame.args[1].int32()] = jsNumber(number + 1);
+    return JSValue::encode(jsNumber(number));
 }
 
@@ -3349 +3349 @@
     CallFrame* callFrame = stackFrame.callFrame;
 
-    JSValue number = v.toJSNumber(callFrame);
-    CHECK_FOR_EXCEPTION_AT_END();
-
-    callFrame->registers()[stackFrame.args[1].int32()] = jsNumber(number.asNumber() - 1);
-    return JSValue::encode(number);
+    double number = v.toNumber(callFrame);
+    CHECK_FOR_EXCEPTION_AT_END();
+
+    callFrame->registers()[stackFrame.args[1].int32()] = jsNumber(number - 1);
+    return JSValue::encode(jsNumber(number));
 }
 
@@ -3583 +3583 @@
     CallFrame* callFrame = stackFrame.callFrame;
 
-    JSValue result = src.toJSNumber(callFrame);
-    CHECK_FOR_EXCEPTION_AT_END();
-    return JSValue::encode(result);
+    double number = src.toNumber(callFrame);
+    CHECK_FOR_EXCEPTION_AT_END();
+    return JSValue::encode(jsNumber(number));
 }