Changeset 96729 in webkit for trunk/Source/JavaScriptCore/ChangeLog

Timestamp:

Oct 5, 2011, 11:15:55 AM (14 years ago)

Author:

[email protected]

Message:

Make Object.prototype getter/setter methods match ES5 behaviour
​https://bugs.webkit.org/show_bug.cgi?id=69393

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The rest of Object.prototype no longer substitute Null/Undefined with the global object,
this is old ES3 behaviour. Remove it here too.

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

LayoutTests:

Update tests to conform with ES5 style handling of 'this' in host functions.

• fast/dom/Window/Location/window-override-location-using-defineGetter.html:
• fast/dom/Window/Location/window-override-window-using-defineGetter.html:
• fast/js/exception-sequencing-binops.js:
• fast/js/exception-sequencing.html:
• fast/js/pic/delete-global-object.html:

File:

• trunk/Source/JavaScriptCore/ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-10-04  Gavin Barraclough  <[email protected]>
+
+        Make Object.prototype getter/setter methods match ES5 behaviour
+        https://bugs.webkit.org/show_bug.cgi?id=69393
+
+        Reviewed by Sam Weinig.
+
+        The rest of Object.prototype no longer substitute Null/Undefined with the global object,
+        this is old ES3 behaviour. Remove it here too.
+
+        * runtime/ObjectPrototype.cpp:
+        (JSC::objectProtoFuncDefineGetter):
+        (JSC::objectProtoFuncDefineSetter):
+        (JSC::objectProtoFuncLookupGetter):
+        (JSC::objectProtoFuncLookupSetter):
+
 2011-10-05  Patrick Gansterer  <[email protected]>