Changeset 96881 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Oct 6, 2011, 5:34:05 PM (14 years ago)

Author:

[email protected]

Message:

When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
​https://bugs.webkit.org/show_bug.cgi?id=69586

Reviewed by Darin Adler.

../JavaScriptCore:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

• JavaScriptCore.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

• jsc.cpp:

(runInteractive):
Move interpreterName into runInteractive.

• wtf/StdLibExtras.h:

When building with clang, disable the -Wglobal-constructors and -Wexit-time-destructors
warnings around the variable declaration.

../JavaScriptGlue:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

• JavaScriptGlue.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

../WebCore:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

• WebCore.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

• platform/graphics/filters/FEGaussianBlur.cpp:

(gaussianKernelFactor):
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::calculateStdDeviation):
Change the gaussian kernel factor global to be an inline function instead.

../WebKit:

• WebKit.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

../WebKit/mac:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

../WebKit2:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

• WebKit2.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -116 +116 @@
 
 static const char interactivePrompt[] = "> ";
-static const UString interpreterName("Interpreter");
 
 class StopWatch {
@@ -480 +479 @@
 static void runInteractive(GlobalObject* globalObject)
 {
+    UString interpreterName("Interpreter");
+
     while (true) {
 #if HAVE(READLINE) && !RUNNING_FROM_XCODE