Changeset 97002 in webkit for trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

Timestamp:

Oct 7, 2011, 11:37:45 PM (14 years ago)

Author:

[email protected]

Message:

Add static version of JSCell::deleteProperty
​https://bugs.webkit.org/show_bug.cgi?id=69659

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::deleteProperty.

• API/JSCallbackObject.h:
• API/JSCallbackObjectFunctions.h:

(JSC::::deleteProperty):

• debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::deleteProperty):

• debugger/DebuggerActivation.h:
• runtime/Arguments.cpp:

(JSC::Arguments::deleteProperty):

• runtime/Arguments.h:
• runtime/JSActivation.cpp:

(JSC::JSActivation::deleteProperty):

• runtime/JSActivation.h:
• runtime/JSArray.cpp:

(JSC::JSArray::deleteProperty):

• runtime/JSArray.h:
• runtime/JSCell.cpp:

(JSC::JSCell::deleteProperty):

• runtime/JSCell.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::deleteProperty):

• runtime/JSFunction.h:
• runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::deleteProperty):

• runtime/JSNotAnObject.h:
• runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

• runtime/JSObject.h:
• runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):

• runtime/JSVariableObject.h:
• runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::deleteProperty):

• runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::deleteProperty):

• runtime/StrictEvalActivation.h:
• runtime/StringObject.cpp:

(JSC::StringObject::deleteProperty):

• runtime/StringObject.h:

Source/WebCore:

No new tests.

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions. This is the first step in de-virtualizing JSCell::deleteProperty.

• bridge/objc/objc_runtime.h:
• bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):

• bridge/runtime_array.cpp:

(JSC::RuntimeArray::deleteProperty):

• bridge/runtime_array.h:
• bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::deleteProperty):

• bridge/runtime_object.h:

File:

• trunk/Source/JavaScriptCore/runtime/JSFunction.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

@@ -330 +330 @@
 bool JSFunction::deleteProperty(ExecState* exec, const Identifier& propertyName)
 {
-    if (isHostFunction())
-        return Base::deleteProperty(exec, propertyName);
+    return deleteProperty(this, exec, propertyName);
+}
+
+bool JSFunction::deleteProperty(JSCell* cell, ExecState* exec, const Identifier& propertyName)
+{
+    JSFunction* thisObject = static_cast<JSFunction*>(cell);
+    if (thisObject->isHostFunction())
+        return Base::deleteProperty(thisObject, exec, propertyName);
     if (propertyName == exec->propertyNames().arguments || propertyName == exec->propertyNames().length)
         return false;
-    return Base::deleteProperty(exec, propertyName);
+    return Base::deleteProperty(thisObject, exec, propertyName);
 }