Changeset 98082 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp

Timestamp:

Oct 21, 2011, 1:19:03 AM (14 years ago)

Author:

[email protected]

Message:

DFG should not try to predict argument types by looking at the values of
argument registers at the time of compilation
​https://bugs.webkit.org/show_bug.cgi?id=70578

Reviewed by Oliver Hunt.

• bytecode/CodeBlock.cpp:
• dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

• dfg/DFGDriver.h:

(JSC::DFG::tryCompileFunction):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

• dfg/DFGGraph.h:
• runtime/Executable.cpp:

(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

• runtime/Executable.h:

(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):

File:

• trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp

@@ -36 +36 @@
 
 enum CompileMode { CompileFunction, CompileOther };
-inline bool compile(CompileMode compileMode, ExecState* exec, ExecState* calleeArgsExec, CodeBlock* codeBlock, JITCode& jitCode, MacroAssemblerCodePtr* jitCodeWithArityCheck)
+inline bool compile(CompileMode compileMode, ExecState* exec, CodeBlock* codeBlock, JITCode& jitCode, MacroAssemblerCodePtr* jitCodeWithArityCheck)
 {
     JSGlobalData* globalData = &exec->globalData();
@@ -44 +44 @@
     
     if (compileMode == CompileFunction)
-        dfg.predictArgumentTypes(calleeArgsExec, codeBlock);
+        dfg.predictArgumentTypes(codeBlock);
     
     propagate(dfg, globalData, codeBlock);
@@ -65 +65 @@
 bool tryCompile(ExecState* exec, CodeBlock* codeBlock, JITCode& jitCode)
 {
-    return compile(CompileOther, exec, 0, codeBlock, jitCode, 0);
+    return compile(CompileOther, exec, codeBlock, jitCode, 0);
 }
 
-bool tryCompileFunction(ExecState* exec, ExecState* calleeArgsExec, CodeBlock* codeBlock, JITCode& jitCode, MacroAssemblerCodePtr& jitCodeWithArityCheck)
+bool tryCompileFunction(ExecState* exec, CodeBlock* codeBlock, JITCode& jitCode, MacroAssemblerCodePtr& jitCodeWithArityCheck)
 {
-    return compile(CompileFunction, exec, calleeArgsExec, codeBlock, jitCode, &jitCodeWithArityCheck);
+    return compile(CompileFunction, exec, codeBlock, jitCode, &jitCodeWithArityCheck);
 }