Ignore:
Timestamp:
Nov 3, 2011, 11:20:08 AM (14 years ago)
Author:
[email protected]
Message:

De-virtualize JSObject::className
https://bugs.webkit.org/show_bug.cgi?id=71428

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::className):

(JSC::DebuggerActivation::className):

  • debugger/DebuggerActivation.h:
  • jsc.cpp:

(GlobalObject::createStructure):

  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::className):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::className):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • testRegExp.cpp:

(GlobalObject::createStructure):

Source/JavaScriptGlue:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • JSUtils.cpp:

(KJSValueToCFTypeInternal):

Source/WebCore:

No new tests.

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::className):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::internalConstructorName):

  • bridge/testqtbindings.cpp:

(Global::className):

Source/WebKit/efl:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • ewk/ewk_js.cpp:

(ewk_js_npobject_to_object):

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/profiler/Profiler.cpp

    r95901 r99223  
    173173    if (asObject(functionValue)->inherits(&InternalFunction::s_info))
    174174        return CallIdentifier(static_cast<InternalFunction*>(asObject(functionValue))->name(exec), defaultSourceURL, defaultLineNumber);
    175     return CallIdentifier(makeUString("(", asObject(functionValue)->className(), " object)"), defaultSourceURL, defaultLineNumber);
     175    return CallIdentifier(makeUString("(", asObject(functionValue)->methodTable()->className(asObject(functionValue)), " object)"), defaultSourceURL, defaultLineNumber);
    176176}
    177177
Note: See TracChangeset for help on using the changeset viewer.