Changeset 99497 in webkit for trunk/Source/JavaScriptCore/debugger/DebuggerActivation.h

Timestamp:

Nov 7, 2011, 3:57:37 PM (14 years ago)

Author:

[email protected]

Message:

De-virtualize JSObject::putWithAttributes
​https://bugs.webkit.org/show_bug.cgi?id=71716

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

• API/JSObjectRef.cpp:

(JSObjectSetProperty):

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::putWithAttributes):

• debugger/DebuggerActivation.h:
• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• runtime/ClassInfo.h:
• runtime/JSActivation.cpp:

(JSC::JSActivation::putWithAttributes):

• runtime/JSActivation.h:
• runtime/JSCell.cpp:

(JSC::JSCell::putWithAttributes):

• runtime/JSCell.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::putWithAttributes):

• runtime/JSGlobalObject.h:
• runtime/JSObject.cpp:

(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):

• runtime/JSObject.h:
• runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::putWithAttributes):

• runtime/JSStaticScopeObject.h:
• runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::putWithAttributes):

• runtime/JSVariableObject.h:

Source/WebCore:

No new tests.

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

• bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putWithAttributes):

• bindings/js/JSDOMWindowShell.h:

File:

• trunk/Source/JavaScriptCore/debugger/DebuggerActivation.h (modified) (1 diff)

trunk/Source/JavaScriptCore/debugger/DebuggerActivation.h

@@ -46 +46 @@
         static bool getOwnPropertySlot(JSCell*, ExecState*, const Identifier& propertyName, PropertySlot&);
         static void put(JSCell*, ExecState*, const Identifier& propertyName, JSValue, PutPropertySlot&);
-        virtual void putWithAttributes(ExecState*, const Identifier& propertyName, JSValue, unsigned attributes);
+        static void putWithAttributes(JSObject*, ExecState*, const Identifier& propertyName, JSValue, unsigned attributes);
         static bool deleteProperty(JSCell*, ExecState*, const Identifier& propertyName);
         static void getOwnPropertyNames(JSObject*, ExecState*, PropertyNameArray&, EnumerationMode);