Changeset 99497 in webkit for trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

Timestamp:

Nov 7, 2011, 3:57:37 PM (14 years ago)

Author:

[email protected]

Message:

De-virtualize JSObject::putWithAttributes
​https://bugs.webkit.org/show_bug.cgi?id=71716

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

• API/JSObjectRef.cpp:

(JSObjectSetProperty):

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::putWithAttributes):

• debugger/DebuggerActivation.h:
• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• runtime/ClassInfo.h:
• runtime/JSActivation.cpp:

(JSC::JSActivation::putWithAttributes):

• runtime/JSActivation.h:
• runtime/JSCell.cpp:

(JSC::JSCell::putWithAttributes):

• runtime/JSCell.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::putWithAttributes):

• runtime/JSGlobalObject.h:
• runtime/JSObject.cpp:

(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):

• runtime/JSObject.h:
• runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::putWithAttributes):

• runtime/JSStaticScopeObject.h:
• runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::putWithAttributes):

• runtime/JSVariableObject.h:

Source/WebCore:

No new tests.

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

• bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putWithAttributes):

• bindings/js/JSDOMWindowShell.h:

File:

• trunk/Source/JavaScriptCore/runtime/JSActivation.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

@@ -182 +182 @@
 
 // FIXME: Make this function honor ReadOnly (const) and DontEnum
-void JSActivation::putWithAttributes(ExecState* exec, const Identifier& propertyName, JSValue value, unsigned attributes)
-{
-    ASSERT(!Heap::heap(value) || Heap::heap(value) == Heap::heap(this));
-
-    if (symbolTablePutWithAttributes(exec->globalData(), propertyName, value, attributes))
+void JSActivation::putWithAttributes(JSObject* object, ExecState* exec, const Identifier& propertyName, JSValue value, unsigned attributes)
+{
+    JSActivation* thisObject = static_cast<JSActivation*>(object);
+    ASSERT(!Heap::heap(value) || Heap::heap(value) == Heap::heap(thisObject));
+
+    if (thisObject->symbolTablePutWithAttributes(exec->globalData(), propertyName, value, attributes))
         return;
 
@@ -192 +193 @@
     // properties are non-standard extensions that other implementations do not
     // expose in the activation object.
-    ASSERT(!hasGetterSetterProperties());
-    JSObject::putWithAttributes(exec, propertyName, value, attributes);
+    ASSERT(!thisObject->hasGetterSetterProperties());
+    JSObject::putWithAttributes(thisObject, exec, propertyName, value, attributes);
 }