Changeset 99556 in webkit for trunk/Source/WebCore/css/CSSGradientValue.h

Timestamp:

Nov 8, 2011, 5:23:24 AM (14 years ago)

Author:

[email protected]

Message:

CSSGradientValue: Devirtualize createGradient().
<​http://webkit.org/b/71800>

Reviewed by Antti Koivisto.

Make createGradient() non-virtual and call the appropriate subclass
implementation in image() based on is{Linear,Radial}Gradient().

• css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):

• css/CSSGradientValue.h:

File:

• trunk/Source/WebCore/css/CSSGradientValue.h (modified) (5 diffs)

trunk/Source/WebCore/css/CSSGradientValue.h

@@ -78 +78 @@
     void addStops(Gradient*, RenderObject*, RenderStyle* rootStyle, float maxLengthForRepeat = 0);
 
-    // Create the gradient for a given size.
-    virtual PassRefPtr<Gradient> createGradient(RenderObject*, const IntSize&) = 0;
-
     // Resolve points/radii to front end values.
     FloatPoint computeEndPoint(CSSPrimitiveValue*, CSSPrimitiveValue*, RenderStyle*, RenderStyle* rootStyle, const IntSize&);
@@ -112 +109 @@
     virtual String cssText() const;
 
+    // Create the gradient for a given size.
+    PassRefPtr<Gradient> createGradient(RenderObject*, const IntSize&);
+
 private:
     CSSLinearGradientValue(CSSGradientRepeat repeat, bool deprecatedType = false)
@@ -117 +117 @@
     {
     }
-
-    // Create the gradient for a given size.
-    virtual PassRefPtr<Gradient> createGradient(RenderObject*, const IntSize&);
 
     RefPtr<CSSPrimitiveValue> m_angle; // may be null.
@@ -142 +139 @@
     void setEndVerticalSize(PassRefPtr<CSSPrimitiveValue> val) { m_endVerticalSize = val; }
 
+    // Create the gradient for a given size.
+    PassRefPtr<Gradient> createGradient(RenderObject*, const IntSize&);
+
 private:
     CSSRadialGradientValue(CSSGradientRepeat repeat, bool deprecatedType = false)
@@ -147 +147 @@
     {
     }
-
-    // Create the gradient for a given size.
-    virtual PassRefPtr<Gradient> createGradient(RenderObject*, const IntSize&);
 
     // Resolve points/radii to front end values.