Changeset 99608 in webkit for trunk/Source/JavaScriptCore/parser/Parser.cpp

Timestamp:

Nov 8, 2011, 12:37:52 PM (14 years ago)

Author:

[email protected]

Message:

JSC::Parser::Parser leaks Lexer member
​https://bugs.webkit.org/show_bug.cgi?id=71847

Changed m_lexer member of Parser to be OwnPtr to fix a memory leak.

Reviewed by Oliver Hunt.

• parser/Parser.cpp:

(JSC::Parser::Parser):
(JSC::Parser::parseFunctionBody):

• parser/Parser.h:

File:

• trunk/Source/JavaScriptCore/parser/Parser.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -58 +58 @@
     , m_sourceElements(0)
 {
-    m_lexer = new Lexer<UChar>(globalData);
+    m_lexer = adoptPtr(new Lexer<UChar>(globalData));
     m_arena = m_globalData->parserArena;
     m_lexer->setCode(source, m_arena);
@@ -741 +741 @@
     DepthManager statementDepth(&m_statementDepth);
     m_statementDepth = 0;
-    typename TreeBuilder::FunctionBodyBuilder bodyBuilder(const_cast<JSGlobalData*>(m_globalData), m_lexer);
+    typename TreeBuilder::FunctionBodyBuilder bodyBuilder(const_cast<JSGlobalData*>(m_globalData), m_lexer.get());
     failIfFalse(parseSourceElements<CheckForStrictMode>(bodyBuilder));
     return context.createFunctionBody(m_lexer->lastLineNumber(), strictMode());