Skip to content

Design issue fixed in category page magento2#30397 #30406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

saumya1998
Copy link

@saumya1998 saumya1998 commented Oct 10, 2020

Description (*)

Fixed #30397 count design issue fixed

Preconditions (*)
PHP 7.4.11
magento2-2.4

Manual testing scenarios (*)
1.Open magento base url.
2.Go to category page.
3.Go to Shopping Options on left side of page.
4.Open any CATEGORY/PRICE dropdown.
5.Check count design.

Expected result (*)
https://user-images.githubusercontent.com/50991251/95648439-c8acd500-0af4-11eb-9517-0108d76889f6.png

Actual result (*)
https://user-images.githubusercontent.com/50991251/95648477-1d505000-0af5-11eb-956c-154f3bf1c189.png

@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2020

Hi @saumya1998. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@saumya1998 saumya1998 changed the title Design issue fixed in magento2#30397 Design issue fixed in category page magento2#30397 Oct 10, 2020
@vijay-wagento
Copy link

#dmcdindia2020

@saumya1998
Copy link
Author

#dmcdindia2020

@sivaschenko sivaschenko added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 10, 2020
@mrtuvn
Copy link
Contributor

mrtuvn commented Oct 10, 2020

Sorry but seem your fix not correctly solve to root cause. You should not try to align element with fixed value
I already have the fix related with this area
See this #30333
CC: @sivaschenko

@ptylek
Copy link
Contributor

ptylek commented Oct 12, 2020

I agree with @mrtuvn that this is not the correct approach.

As this has been already solved and accepted in #30333 I am adding duplicate label and closing this PR.

@ptylek ptylek closed this Oct 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 12, 2020

Hi @saumya1998, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend duplicate Event: dmcdindia2020 Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: pending review Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design issue in category page , in Shopping Options dropdown, the count value alignment is not right.
6 participants