Skip to content

Conversation

cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Jun 10, 2025

Followup to rust-lang/team#1860.

Question: should the ICEBreaker-Cleanup-Crew Helping to "clean up" bugs with minimal examples and bisections and ICEBreaker-LLVM Bugs identified for the LLVM ICE-breaker group labels be deleted too or not?

@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

📌 Commit 296f9f2 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Jun 11, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Re. the labels, maybe? I guess we can keep the label for now

bors added a commit that referenced this pull request Jun 11, 2025
Rollup of 9 pull requests

Successful merges:

 - #142305 (Remove unneeded `check_id` calls as they are already called in `visit_id` in `EarlyContextAndPass` type)
 - #142314 (remove ice group pings from `triagebot.toml`)
 - #142343 (remove myself from the project)
 - #142346 (Add tracing import to execution context)
 - #142356 (Fix enter_trace_span!() using wrong $crate paths)
 - #142362 (Add expectation for `{` when parsing lone coroutine qualifiers)
 - #142364 (Do not warn on `rust.incremental` when using download CI rustc)
 - #142369 (Improve some attribute docs and rename groups)
 - #142374 (Fix missing newline trim in bootstrap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit deea067 into rust-lang:master Jun 12, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 12, 2025
rust-timer added a commit that referenced this pull request Jun 12, 2025
Rollup merge of #142314 - cyrgani:icebreaker, r=jieyouxu

remove ice group pings from `triagebot.toml`

Followup to rust-lang/team#1860.

Question: should the https://github.com/rust-lang/rust/labels/ICEBreaker-Cleanup-Crew and https://github.com/rust-lang/rust/labels/ICEBreaker-LLVM labels be deleted too or not?
@cyrgani cyrgani deleted the icebreaker branch June 12, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants