Reactive SwitchUserWebFilter for user impersonation #8687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleftherias
suggested changes
Jun 22, 2020
There was a problem hiding this comment.
Thanks for the PR @aotrzonsek!
I have left some feedback inline.
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/web/server/authentication/SwitchUserWebFilter.java
Outdated
Show resolved
Hide resolved
b9d5eb5 to
5590f29
Compare
eleftherias
suggested changes
Jul 10, 2020
There was a problem hiding this comment.
Thanks for the updates @aotrzonsek!
I have left a few more comments.
There are also some comments from the previous review that are unresolved (test names and Javadocs)
|
|
||
| /** | ||
| * Switch User processing filter responsible for user context switching. | ||
| * It is a reactive reimplementation of the |
There was a problem hiding this comment.
We should have the full explanation of the filter here, rather than directing the users to look at SwitchUserFilter.
|
|
||
| /** | ||
| * @author Artur Otrzonsek | ||
| * @since 5.2.6 |
There was a problem hiding this comment.
We don't need to add @since for test classes.
Before: It was not possible to switch the user context by using Spring WebFlux Security After: Added an appropriate filter that allows switch the user context in Spring WebFlux Security Closes spring-projectsgh-8599
5590f29 to
98b472b
Compare
|
Thanks @aotrzonsek! This is now merged into master via b22c50c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
It was not possible to switch the user context by using Spring WebFlux Security
After:
Added an appropriate filter that allows switch the user context in Spring WebFlux Security
Closes gh-8599