fix: do cleanup when removeAngularAttributes is enabled #69
Conversation
| @@ -0,0 +1 @@ | |||
| declare function afterEach(fn: () => {}, timeout?: number): void; | |||
There was a problem hiding this comment.
Is this needed to run tests in CI?
There was a problem hiding this comment.
In the IDE it shows an error (duplicate identifier)
There was a problem hiding this comment.
Needed to be able to build
| @@ -236,3 +239,12 @@ function addAutoImports({ imports, routes }: Pick<RenderComponentOptions<any>, ' | |||
|
|
|||
| return [...imports, ...animations(), ...routing()]; | |||
| } | |||
|
|
|||
| if (typeof afterEach === 'function' && !process.env.ATL_SKIP_AUTO_CLEANUP) { | |||
There was a problem hiding this comment.
When process.env.ATL_SKIP_AUTO_CLEANUP is going to be neccessary?
There was a problem hiding this comment.
It's to be consistent with the rest of the testing libraries
| @@ -73,6 +75,7 @@ export async function render<SutType, WrapperType = SutType>( | |||
| const idAttribute = fixture.nativeElement.getAttribute('id'); | |||
| if (idAttribute && idAttribute.startsWith('root')) { | |||
| fixture.nativeElement.removeAttribute('id'); | |||
| cleanup = () => fixture.nativeElement.setAttribute('id', idAttribute); | |||
There was a problem hiding this comment.
I restore only the id, because it's the only attribute that Angular need to remove old roots. Should do we restore ng-version too?
There was a problem hiding this comment.
Sorry I wasn't clear, I will follow-up with another PR
|
@allcontributors please add @tonivj5 for bug, code |
|
I've put up a pull request to add @tonivj5! 🎉 |
I have taken your branch to add my changes. I think this approach is cleaner, however, I'm okei with your fix, if you prefer it over this, close this PR 👍
Fixing this issue,
removeAngularAttributescan be enabled by default without problems 🎉Closes #67