Changeset 130761 in webkit for trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

Timestamp:

Oct 9, 2012, 7:46:53 AM (13 years ago)

Author:

[email protected]

Message:

After r130344, OpaqueJSString::identifier() adds wrapped String to identifier table
​https://bugs.webkit.org/show_bug.cgi?id=98693
REGRESSION (r130344): Install failed in Install Environment
<rdar://problem/12450118>

Reviewed by Filip Pizlo.

Use Identifier(LChar*, length) or Identifier(UChar*, length) constructors so that we don't
add the String instance in the OpaqueJSString to any identifier tables.

• API/OpaqueJSString.cpp:

(OpaqueJSString::identifier):

File:

• trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

@@ -45 +45 @@
         return Identifier(globalData, static_cast<const char*>(0));
 
-    return Identifier(globalData, m_string);
+    if (m_string.is8Bit())
+        return Identifier(globalData, m_string.characters8(), m_string.length());
+
+    return Identifier(globalData, m_string.characters16(), m_string.length());
 }